CCNET-Plugin 4.1.4: using Multi source control fails

[avonwyss]

We have a CCNET setup and use the native Vault plugin V4.1.4. Unfortunately, the plugin fails on a project using a nested source control definition to access two repositories for one build (on the same Vault server with the same saved credentials). The definition is the following:

Code: Select all

		<sourcecontrol type="multi">
			<sourceControls>
				<vaultplugin>
					<repository>Repo1</repository>
					<folder>$/Path1/</folder>
					<autoGetSource>true</autoGetSource>
				</vaultplugin>
				<filtered>
					<sourceControlProvider type="vaultplugin">
						<repository>Repo2</repository>
						<folder>$/Path2/</folder>
						<autoGetSource>true</autoGetSource>
					</sourceControlProvider>
					<exclusionFilters>
						<userFilter>
							<names>
								<name>someuser</name>
							</names>
						</userFilter>
					</exclusionFilters>
				</filtered>
			</sourceControls>
		</sourcecontrol>

When building, we get the following error:

Code: Select all

2009-02-03 14:40:08,135 [PROJ:INFO] Building: avonwyss triggered a build (ForceBuild)
2009-02-03 14:40:08,135 [PROJ:DEBUG] In FortressVaultSourceControl.GetSource()
2009-02-03 14:40:08,135 [PROJ:DEBUG] Retrieved Session Info
2009-02-03 14:40:08,197 [PROJ:ERROR] Vault Login Failed: System.Exception: Internal error: An attempt was made to connect to a server when already connected to a server.
   at VaultClientNetLib.VaultConnection.Login(String strURLBase, String strUserLogin, String strPassword)
   at VaultClientOperationsLib.ClientInstance.Login(String urlbase, String username, String password)
   at ThoughtWorks.CruiseControl.Core.Sourcecontrol.FortressClient.Login(String vaultHost, String vaultRepositoryName, String vaultUser, String vaultPassword, Boolean useSSL, String proxyHost, String proxyDomain, Int32 proxyPort, String proxyUser, String proxyPassword, String& url)
2009-02-03 14:40:08,197 [PROJ:DEBUG] In FortressVaultSourceControl.GetSource()
2009-02-03 14:40:08,213 [PROJ:INFO] Getting source from Vault

Additional info/update: as it turns out, the repository was not accessible for this user due to misconfiguration. After reverting to the other CCNET plugin, I got the message that the Repo1 was not accessible, which helped me fix the issue. However, I believe that the handling of the error when a repository cannot be found (could also be due to a typo or so) could be better.

[Beth]

However, I believe that the handling of the error when a repository cannot be found (could also be due to a typo or so) could be better.

Thank you for the update. I will put in a request for better error handling there. Thanks for the feedback.

F: 13957