Silent Error when Committing

If you are having a problem using Vault, post a message here.

Moderator: SourceGear

Post Reply
TIMMCS
Posts: 3
Joined: Tue Jun 17, 2008 11:02 am

Silent Error when Committing

Post by TIMMCS » Tue Jun 17, 2008 12:39 pm

Using vault 4.1.2.18185, Visual Studio Enhanced Client, Visual Studio 2005, v 8.0.50727.762 (SP.050727-7600).

Symtoms:
When clicking the Commit All button in the Vault Pending Changes window, after confirming the changes (adding 3 files), the Commit/uploading files window appears for a moment and then closes. No error is reported, but the files are not uploaded. I have determined the cause of the error to be that the files that visual studio is trying to add already exist in the repository. I would expect that the vault client should report an error indicating that the files already exist rather than silently ignore the command to commit the changes. It took quite a while of checking in the other changes one at a time to isolate which files were causing the commit to fail.

Steps to Reproduce:
1.Open project B in VS2005, bound to vault using enhanced client
2.Using the vault IDE, share a file from project A to project B, commit, and get latest on the file in Project B
3.Using VS2005, add the shared file to project B as an existing item
4.At this point the Vault Pending Changes window will list the shared file as needing to be added. This is incorrect but given the prior steps not unexpected.
5.Click Commit All. The operation will appear to the user to succeed. However, when going back to the vault pending changes window, the operation will not be committed. No error message is displayed.

The problem resolves itself after closing the VS2005 IDE and reopening, as the vault client then correctly realized the newly added file is already under source control and does not want to add it.

I would consider there to be two separate defects here:
1.) At step 4, the vault client should detect that the file being added to the project is already under source control instead of assuming it should be added
2.) At step 5, the user should receive an indication (preferably an error message) that the operation failed instead of the perception that it succeeded.

A feature request would be to add a more elegant method for sharing files (or maybe there is a better way that I should be pointed to)

Thanks

TIMMCS
Posts: 3
Joined: Tue Jun 17, 2008 11:02 am

Problem does not resolve itself

Post by TIMMCS » Tue Jun 17, 2008 12:44 pm

Sorry, the problem did not resolve itself when restarting VS2005. For some reason the vault client connected in offline mode so I didn't see the pending changes. When returning to online mode, the system wanted to add the files. Telling the vault client to undo the selected operation on the newly added file(s) resolved the problem.

Beth
Posts: 8550
Joined: Wed Jun 21, 2006 8:24 pm
Location: SourceGear
Contact:

Post by Beth » Tue Jun 17, 2008 1:17 pm

I reproduced this. I wouldn't have expected this either. I will get this logged as a bug. Thanks for the report.

Post Reply