Critical: Failed deleting label after 3.5.1 upgrade

ismangil · Post by **ismangil** » Fri Sep 22, 2006 5:53 am

On a test server I have upgraded our 3.1.7 to 3.5.1. Everything seemed fine until I had to delete labels (log attached). On another clean 3.5.1 install deleting label works fine, so I assume this is something to do with an upgraded database.

Any resolution?

# SourceGear Vault Server
----9/22/2006 12:11:13 PM [masked]--SSL Disabled TreeManager: cache matches repository revision and folder security hasn't changed. Returning cached tree, revID 74454
----9/22/2006 12:11:13 PM [masked]--SSL Disabled BeginLabelQuery returned: Success
----9/22/2006 12:11:14 PM [masked]--SSL Disabled GetLabelQueryItems returned: Success
----9/22/2006 12:11:14 PM [masked]--SSL Disabled GetLabelQueryItems returned: Success
----9/22/2006 12:11:18 PM [masked]--SSL Disabled EndLabelQuery returned: Success
----9/22/2006 12:11:18 PM [masked]--SSL Disabled TreeManager: cache matches repository revision and folder security hasn't changed. Returning cached tree, revID 74454
----9/22/2006 12:11:18 PM [masked]--SSL Disabled BeginLabelQuery returned: Success
----9/22/2006 12:11:18 PM [masked]--SSL Disabled GetLabelQueryItems returned: Success
----9/22/2006 12:11:19 PM [masked]--SSL Disabled GetLabelQueryItems returned: Success
----9/22/2006 12:11:26 PM [masked]--SSL Disabled TreeManager: cache matches repository revision and folder security hasn't changed. Returning cached tree, revID 74454
----9/22/2006 12:11:26 PM [masked]--SSL Disabled System.Data.SqlClient.SqlException: Procedure spdeletefsobjectlabel has no parameters and arguments were supplied.
at System.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream)
at System.Data.SqlClient.SqlCommand.ExecuteNonQuery()
at VaultServiceSQL.VaultSqlSCC.DeleteLabel(VaultSqlConn conn, Int32 nRepID, Int64 nLabelID, Int64 nObjID) at System.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream)
at System.Data.SqlClient.SqlCommand.ExecuteNonQuery()
at VaultServiceSQL.VaultSqlSCC.DeleteLabel(VaultSqlConn conn, Int32 nRepID, Int64 nLabelID, Int64 nObjID)
----9/22/2006 12:11:26 PM [masked]--SSL Disabled DeleteLabel returned: FailDBDelete
----9/22/2006 12:11:26 PM [masked]--SSL Disabled EndLabelQuery returned: Success
----9/22/2006 12:11:26 PM [masked]--SSL Disabled TreeManager: cache matches repository revision and folder security hasn't changed. Returning cached tree, revID 74454
----9/22/2006 12:11:26 PM [masked]--SSL Disabled BeginLabelQuery returned: Success
----9/22/2006 12:11:26 PM [masked]--SSL Disabled GetLabelQueryItems returned: Success
----9/22/2006 12:11:26 PM [masked]--SSL Disabled GetLabelQueryItems returned: Success
----9/22/2006 12:11:33 PM [masked]--SSL Disabled EndLabelQuery returned: Success

lbauer · Post by **lbauer** » Fri Sep 22, 2006 10:13 am

If you create a new label, can you delete it?

Do you get this error just on labels prior to the upgrade?

Does deleting a label fail on any older label?

What version of SQL Server are you using?

ismangil · Post by **ismangil** » Mon Sep 25, 2006 2:21 am

lbauer wrote:If you create a new label, can you delete it?

No, I can't. New labels are created just fine, but deleting it causes the same error.

lbauer wrote:Do you get this error just on labels prior to the upgrade?

No, also on new labels.

lbauer wrote: Does deleting a label fail on any older label?

Yes.

lbauer wrote: What version of SQL Server are you using?

SQL Server 2000 SP3

lbauer · Post by **lbauer** » Mon Sep 25, 2006 9:50 am

Run this query:

USE sgvault
GO
sp_help 'dbo.spdeletefsobjectlabel'
GO

What are the results?

ismangil · Post by **ismangil** » Mon Sep 25, 2006 9:57 am

lbauer wrote:Run this query:

USE sgvault
GO
sp_help 'dbo.spdeletefsobjectlabel'
GO

What are the results?

spdeletefsobjectlabel dbo stored procedure 2006-09-18 17:47:16.870

lbauer · Post by **lbauer** » Mon Sep 25, 2006 12:23 pm

When I ran the query on my sgvault database I also got this:

@repid int 4 10 0 1 NULL
@labelid bigint 8 19 0 2 NULL
@objid bigint 8 19 0 3 NULL

It looks like some parameters are missing in your database.

The best bet would be to re-install the Vault Server so the database stored procedures are updated. You could try the repair option or uninstall, keeping the database, then reinstall.

ismangil · Post by **ismangil** » Tue Sep 26, 2006 2:05 am

Repair failed because 'sgvaultuser already exist'. Proceeding to uninstall and reinstall.

ismangil · Post by **ismangil** » Tue Sep 26, 2006 3:11 am

Reinstall (keeping the db) worked. The procedure now has parameters, and deleting labels works.

It would be good if the 'Repair' option worked.

Thanks for all your help.