Exclude...

Thomas Linder Puls · Post by **Thomas Linder Puls** » Mon Feb 28, 2005 6:21 pm

Both when adding and detecting files, there is an "exclude" button.

It seems to me that the default "exclude" values are used to filter the files in the tree.

But changing the value does not change what is shown in the tree.

dan · Post by **dan** » Tue Mar 01, 2005 8:22 am

The Exclude button isn't meant to exclude files from the tree, but to exclude them from being selected on a folder select. This allows you to exclude most files of a given type, but still include a few files that you might want to still be part of the add.

Thomas Linder Puls · Post by **Thomas Linder Puls** » Wed Mar 02, 2005 3:03 am

It would be much nicer to have them excluded from the tree (also it seems that the initial value is used that way (but I have not looked much at it)).

Also (but I have already mentioned this before, but it is even more relevant if you remove the files from the tree) it would be much more convenient if the tree did not contain empty nodes. It is quite irritating to have to expand a large number of empty nodes in order to discover the files you want to add.

If filtering removes files from the tree, then even more nodes might become empty, and the resulting tree might be even smaller (if pruned, that is).

mlippert · Post by **mlippert** » Wed Mar 02, 2005 10:51 am

Just as a voice on the other side, I pretty much like the way it works now.

I prefer that the tree contain everything so I can see what's there, and that the exclude option is used to specify which files/subfolders not to select when a folder is selected.

Mike

Thomas Linder Puls · Post by **Thomas Linder Puls** » Wed Mar 02, 2005 3:36 pm

Do you also want empty folders in the tree?

mlippert · Post by **mlippert** » Wed Mar 02, 2005 4:11 pm

I think I do, for the same reason as before, I want to be able to see everything that is there. Perhaps I want to add that empty folder. In addition for add files, usually all the files that I want to add are in the default selected directory, so having the other folders there doesn't bother me, I ignore it all. If the file I wanted to add was somewhere else, I expect to navigate there as if I were using the Windows Explorer, and I would find it disturbing if existing folders were no shown just because they didn't contain any files.

Your question does bring up a problem I had w/ detect new files to add, however. Namely that it doesn't detect new folders to add. I understand the reason that it doesn't, and unfortunately I don't have a solution to propose. (The reason is the UI. Since the left pane is the current repository tree, and the right pane is files to add to the selected repository folder, how do you deal with folders in the right pane? At least that's what I understand the issue to be.)

Mike

dan · Post by **dan** » Wed Mar 02, 2005 4:50 pm

Good points Mike - the Add Folder dialog is supposed to look like the windows explorer, and reflect the current state of the disk. It would probably confuse a lot of people if it were missing folders.

Thomas, you might want the Detect New Files command. As Mike points, it displays the repository tree and not the local file system, but it does make it easier to see which files have not been added to the repository.

Thomas Linder Puls · Post by **Thomas Linder Puls** » Thu Mar 03, 2005 1:57 am

Well the empty node issue is mainly about the "Detect New Files" command. It does not "reflect the current state of the disk". It shows files on the disk that are not in Vault. Files that are on the disk and also in Vault are not shown.

But let us say that I select $ and then choose "Detect New Files", then the complete tree in the repository is shown, even though there might only be a single file to add in the whole tree. This means that I "cannot" track down the file in the tree, because I have to spend a lot of time looking at empty nodes.

The only way to see the files is to "select the whole tree for addition". This works well if there is only one files to add, but if there are many I see them in a flat list, and then I loose the overview that the tree gives.

So, I would very much like the tree to be without empty nodes. That way I can very fast see which parts of my tree that have additions.

And I would very much like the "Exclude" filter to remove "OBJ" (etc) files from the tree as well.

I would like to add one more thing: If a file is already in the "Pending change Set" for being added, then it should not belisted in the tree. And should I choose "Add" once more (which I of course will not, if the file is not listed), then you should simply ignore the "Add". As it is now the "Add" is put twice in the "Pending Change Set" and the complete transaction fails when committed.

mlippert · Post by **mlippert** » Thu Mar 03, 2005 10:23 am

Ahh, now I understand what you're asking Thomas, and I think I agree with you.

Not showing empty folders in the context of detect new files does make sense (since detect new files doesn't detect new folders anyway). I think some of this may be there in a watered down fashion now (there's no real documentation on what happens when you click on one of the folder checkboxes).

I think the 1st click on a folder checkbox will give you a grey check next to the folder and any subfolder with an added file, excluding files in the exclude list.

Clicking on a grey check seems to make it a bold check and all files are selected even excluded ones. At least that's how I think it works, it's been a little hard to tell and I'm not really sure what the 2nd click does to subfolders.

Mike