Vault API Exception Handling

[awright]

I'm starting to use the Vault API for a project, and I'm wondering if there is a better way to handle exceptions than what I'm doing. I'm using the Vault Standard 6.1 API, and C# 4.0. Currently, it seems that all exceptions coming out of the API are of type System.Exception, instead of something specific to the kind of error that occurred. This is sufficient for printing out error messages to a user, but I can't programmatically distinguish different kinds of exceptions and handle each one differently without (gross) code like this:

Code: Select all

catch (Exception e)
{
    if (e.Message == "The username or password supplied is invalid.")
    {
        // handle invalid credentials
    }
}

Is there something I'm missing, or is this the best approach?

[jclausius]

The API doesn't have the most elegant exception handling, and for uniformity, most client/server exceptions will be by a general exception handler.

Try something like this to see if it sheds some more light on the issue:

Code: Select all

try { ... }
catch (Exception ex)
{
   int nStatusCode = VaultConnection.GetSoapExceptionStatusCodeInt(ex);
   if (VaultLib.VaultStatusCodeFailNotValidLogin == nStatusCode) { System.Console.WriteLine("invalid login: " + VaultLib.GetSoapExceptionMessage(nStatusCode)); }
   else if (nStatusCode != -1) { System.Console.WriteLine("Error was: " + VaultLib.GetSoapExceptionMessage(nStatusCode)); }
   else /* nStatusCode == -1 */ { System.Console.WriteLine("This is not a Vault Protocol exception : " + ex.Message); }
}