BUG: Problem with repository that requires checkin comments

If you are having a problem using Vault, post a message here.

Moderator: SourceGear

Post Reply
cpdaniel
Posts: 25
Joined: Wed Sep 22, 2004 2:47 pm
Location: Sacramento, CA
Contact:

BUG: Problem with repository that requires checkin comments

Post by cpdaniel » Tue Oct 19, 2004 2:34 pm

Using Vault 2.0.6 client and server.

My repository is set to require check-in comments.

If I have a number of modified files in my Pending Changes list, edit the item comment for some of those items, them multi-select the items with comments and choose Commit, Vault complains that check-in comments are required.

Apparently the client is checking for check-in comments for all files in the pending changes list even though only a subset of those files is being checked in.
Carl Daniel
Laru Corporation

dan
Posts: 2448
Joined: Wed Dec 17, 2003 5:03 pm
Location: SourceGear
Contact:

Post by dan » Wed Oct 20, 2004 8:26 am

The Commit button in the pending change set actually includes all items in the pending change set. We are changing the text on that in the next release to "Commit All".

After looking at this, I think the required checkin comments part works properly - you may have just not unchecked the other files that you didn't want to include. Can you verify this? If you still get the error, let me know so I can try to reproduce it here again.

cpdaniel
Posts: 25
Joined: Wed Sep 22, 2004 2:47 pm
Location: Sacramento, CA
Contact:

Post by cpdaniel » Wed Oct 20, 2004 12:29 pm

I've done it dozens of times and I'm quite sure I had only items with check-in comments checked.

I wasn't clear in my original post - I'm not talking about the Commit button, but the Commit option from the context menu within the Pending Changes list after multi-selecting a set of items all of which have check-in comments.

The dialog that appears does indeed list all pending changes, but only the items that were seletected are checked (as it should be).

All that said, on a simple test to reproduce it I wasn't able to - but I've seen the behavior enough and looked at what had comments and check boxes enough to know that it sometimes doesn't work right. I'll keep trying to figure out a real repro.
Carl Daniel
Laru Corporation

cpdaniel
Posts: 25
Joined: Wed Sep 22, 2004 2:47 pm
Location: Sacramento, CA
Contact:

Post by cpdaniel » Wed Oct 20, 2004 1:40 pm

See the attached screenshot.

Here I have 4 files in the Pending changes list, I've added check-in comments for 3 of them, selected all of them and chosen Commit from the context menu.

You can see that:
- All three files have checkin comments
- The three files with comments are checked in the dialog
- The one file without a comment is not checked in the dialog
- Vault griped about the repository requiring check-in comments.
Attachments
vaultbug.jpg
Screen shot of Vault complaining about lack of check in comments when it shouldn't.
vaultbug.jpg (94.31 KiB) Viewed 3702 times
Carl Daniel
Laru Corporation

dan
Posts: 2448
Joined: Wed Dec 17, 2003 5:03 pm
Location: SourceGear
Contact:

Post by dan » Wed Oct 20, 2004 2:12 pm

OK, I've reproduced this here as well. I'll add it to the bug list.

Thanks for the report

Post Reply